Ouranosinc / xclim / 18887188230

92%

push

github

Fix failing tests for upstream xarray with keep attrs change (#2257)

<!--Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [x] This PR addresses an already opened issue (for bug fixes /
features)
    - This PR fixes #2250
- [x] Tests for the changes have been added (for bug fixes / features)
- [ ] (If applicable) Documentation has been added / updated (for bug
fixes / features)
- [x] CHANGELOG.rst has been updated (with summary of main changes)
- [x] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added

### What kind of change does this PR introduce?
We were relying on xarray _not_ preserving the attributes in a few
places, which changed in the upstream branch, where `keep_attrs` is now
True by default.

I tried to only modify the attributes needed to make xclim work.

### Does this PR introduce a breaking change?
No.

### Other information:
This doesn't make sure that xclim outputs are still correct with the new
`keep_attrs` default. I mean, I'm not 100% certain that our current
tests really check all that should be checked. This only fixes the
issues in the CI.

3 of 3 new or added lines in 2 files covered. (100.0%)

7846 of 8517 relevant lines covered (92.12%)

8.08 hits per line