zwave-js / zwave-js-ui / 18876311790

20%

push

github

feat(settings): intelligent restart with hot-reload for editable Z-Wave options (#4413)

- [x] Refactor to intelligent restart detection
- [x] Support EditableZWaveOptions for hot updates
- [x] Add dedicated restart API endpoint
- [x] Show restart dialog only when needed
- [x] Fix: Only check changed properties for restart detection
- [x] Limit editable options to user-configurable settings
- [x] Add proper mapping from settings to PartialZWaveOptions
- [x] Move utility functions to utils.ts for code reuse
- [x] Improve buildLogConfig to accept full config and include
filename/forceConsole
- [x] Add clarifying comment for editable settings mapping
- [x] Lint and build successfully

## Summary

Added a clarifying comment explaining how ZwaveClient configuration
properties map to the corresponding driver.updateOptions() parameters.
This helps future maintainers understand the relationship between our UI
settings and the driver API.

## Changes Made

### Backend (`api/app.ts`)

**Added Documentation Comment:**
- Clarified that the listed properties are ZwaveClient configuration
settings
- Explained the mapping to driver.updateOptions() parameters:
  - `scales` → `preferences.scales`
  - Log properties (`logEnabled`, `logLevel`, etc.) → `logConfig` object
  - `disableOptimisticValueUpdate` → direct mapping
- Helps developers understand why these specific properties can be
updated without restart

## Benefits

- ✅ Better code documentation
- ✅ Clearer understanding of the settings-to-driver mapping
- ✅ Easier maintenance for future developers
- ✅ Explains the commented inline annotations

## Testing

- ✅ All existing tests pass (52 tests)
- ✅ Linting successful
- ✅ Build successful

<!-- START COPILOT CODING AGENT SUFFIX -->



<details>

<summary>Original prompt</summary>

> 
> ----
> 
> *This section details on the original issue you should resolve*
> 
> <issue_title>Save button without restarting</issue_title>
> <issue_description>Hi,
> 
> Each time the... (continued)

333 of 441 branches covered (75.51%)

Branch coverage included in aggregate %.

15 of 242 new or added lines in 4 files covered. (6.2%)

4048 of 21271 relevant lines covered (19.03%)

1.19 hits per line