pantsbuild / pants / 18861553943

80%

push

github

golang: fix Go SDK version check for coverage experiment (#22809)

In the Go backend, limit disabling the "coverage redesign" experiment to
those Go versions where that experiment was actually included. The
`coverageredesign` experiment was removed in Go 1.25, and so an existing
version check needs to account for that change.

## Background

In Go 1.20, Go introduced a new coverage implementation called the
"coverage redesign." Pants did not implement support at the time nor
subsequently. Instead, https://github.com/pantsbuild/pants/pull/18205
disabled the `coverageredesign` experiment so that the "old" coverage
implementation was always used.

In Go 1.25, the coverage redesign implementation is the only
implementation and the old coverage implementation has been removed. The
[relevant conditional in
Pants](https://github.com/pantsbuild/pants/blob/main/src/python/pants/backend/go/util_rules/sdk.py#L162)
needs to account for that fact.

## Testing

Tested by running tests in the
https://github.com/pantsbuild/example-golang repository. Before the fix,
the tests fail; after the fix, they pass. Not sure how to test with
different Go versions being available in Pants CI though. We might need
to update to Go 1.25.x in CI just to make sure the backend generally
works with the latest versions.

0 of 1 new or added line in 1 file covered. (0.0%)

77902 of 97030 relevant lines covered (80.29%)

3.35 hits per line