dcdpr / jp / 18714491347

58%

Build Type

push

github

Committed by web-flow

Commit Message

feat(tools): Add interactive tool inquiry system (#289)

Tools can now ask questions and request user input during execution
through a new inquiry system.

If a tool returns a string that can be parsed into the
`jp_tool::Outcome` type, and the outcome is `Outcome::NeedsInput`, the
user will be prompted for additional input, after which the tool will be
called again with the provided answer.

This change is backward-compatible, as tools that return a string that
cannot be parsed into `Outcome` will result in that string being treated
as the tool's output, similar to how it was before.

This change is generic, and can be used by any tool type supported by JP
(MCP, local, or builtin), but realistically only local or builtin tools
will have dedicated support for this.

To start, file operations automatically prompt for confirmation when
overwriting existing files or deleting files with uncommitted changes,
making destructive operations possible, but not automatic.

A future addition can allow defining automated responses to specific
tool questions through the configuration system, e.g. if you always want
to overwrite existing files with the `fs_create_file` tool, you should
be able to configure this.

A new `jp_tool` crate contains shared types including `Outcome`,
`Question`, and `AnswerType` for the inquiry system.

Signed-off-by: Jean Mertz <git@jeanmertz.com>

Run Details

26 of 179 new or added lines in 17 files covered. (14.53%)

7 existing lines in 6 files now uncovered.

6806 of 14892 relevant lines covered (45.7%)

15.31 hits per line