hydrologie / xhydro / 18694385018

92%

push

github

Small fixes for Windows (#358)

<!-- Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [x] This PR addresses an already opened issue (for bug fixes /
features)
  - This PR fixes #xyz
- [x] (If applicable) Documentation has been added / updated (for bug
fixes / features).
- [x] If changes affect the GIS, Raven Modelling, Extremes.jl or Use
Case Example notebooks, they have been re-run (ReadTheDocs will not
update these).
- [x] If text has changed, ``make initialize-translations`` /
``make-translations.bat`` has been run and translations have been
updated.
- [x] (If applicable) Tests have been added.
- [x] CHANGELOG.rst has been updated (with summary of main changes).
- [x] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added.

### What kind of change does this PR introduce?

* Change the order of arguments in HYDROTEL. I'm not 100% sure that it
matters, but documentation seems to indicate that it does.
* Essentially, add "stdin=subprocess.DEVNULL" to `subprocess` to make
sure that the window closes on Windows systems.
* Add a couple `with open()` to prevent crashes when Windows locks
files.

### Does this PR introduce a breaking change?


### Other information:

11 of 11 new or added lines in 2 files covered. (100.0%)

2891 of 3119 relevant lines covered (92.69%)

4.92 hits per line