zwave-js / zwave-js-ui / 18534313553

20%

push

github

fix(ui): refresh node neighbors when opening node panel in zwave graph (#4416)

## Problem

As noted in #4409, the network map was previously querying neighbors for
all nodes when the graph was rendered, which was inefficient and could
cause performance issues. The suggestion was to refresh neighbors for
only the specific node when its panel is opened, rather than refreshing
all nodes at once.

## Solution

This PR implements targeted neighbor refresh by adding a watcher in
`NodePanel.vue` that automatically calls the `getNodeNeighbors` API when
the node panel is opened. This ensures neighbor information is
up-to-date for the node being viewed without the overhead of querying
all nodes.

### Changes

- Added a watcher on the panel's visibility state (`_value` computed
property)
- Created a new `refreshNodeNeighbors()` method that calls the
`getNodeNeighbors` API
- Only refreshes for non-controller nodes (since controller nodes don't
have neighbors in the same sense)
- Includes silent error handling to gracefully fall back to cached data
if the API call fails

### Behavior

When a user clicks on a node in the Z-Wave graph to view its details:
1. The node panel opens
2. The watcher detects the panel is now visible
3. If the node is valid and not the controller, `getNodeNeighbors` is
called
4. Fresh neighbor data is fetched from the Z-Wave controller
5. The UI automatically updates to show the current neighbor information

This approach is more efficient than the previous implementation, as it
only queries the Z-Wave controller for the specific node being examined,
rather than all nodes in the network.

## Testing

- ✅ All existing tests pass (51 backend + 52 frontend)
- ✅ Lint checks pass
- ✅ Build succeeds
- ✅ Manually tested with mock Z-Wave controller

Closes #4409

> [!WARNING]
>
> <details>
> <summary>Firewall rules blocked me from connecting to one or more
addresses (expand for details)</summary>
>
> #### I tried to connect to the following addres... (continued)

333 of 441 branches covered (75.51%)

Branch coverage included in aggregate %.

4033 of 21081 relevant lines covered (19.13%)

1.2 hits per line