• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

enbility / ship-go / 18464140295
95%

Build:
DEFAULT BRANCH: dev
Ran 13 Oct 2025 11:24AM UTC
Jobs 1
Files 34
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

13 Oct 2025 11:21AM UTC coverage: 95.016% (-0.5%) from 95.55%
18464140295

push

github

web-flow
Critical security and other bugfixes (#58)

- security: fix SKI validation & add fingerprint
  - Calculate SKI from public key using ECDH conversion method
  - Validate certificate SKI matches cryptographically derived value
  - Prevent certificate forgery attacks via SKI field manipulation
  - Ensure RFC 3280 4.2.1.2 method (1) compliance for SHIP protocol
  - Add error case tests
  - Add fingerprint, needed for future functionality
- Fix mDNS incorrect entry merges
- Do not merge mDNS services with the same SKI into a single one. This
would only happen if there would be multiiple mDNS entries claiming the
same SKI.
- Fix IPv6 address format
- The address is already properly formatted for IPv6 using
net.JoinHostPort(), so there is no need to do this manually.
- Fix RemoteSKIConnected not being invoked properly 
- The issue happened, when the service was registered with a known
shipid
- When mDNS entries are removed, stop trying to connect to these
services
- Fix: eliminate connection race conditions from bypass logic

139 of 149 new or added lines in 9 files covered. (93.29%)

19 existing lines in 2 files now uncovered.

3279 of 3451 relevant lines covered (95.02%)

7345.19 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
65.43
-11.21% hub/hub_connections_client.go
2
89.87
0.04% cert/cert.go
2
93.75
cert/fingerprint.go
2
95.83
-0.19% mdns/mdns.go
3
95.31
-4.69% hub/hub_shipconnection.go

Uncovered Existing Lines

Lines Coverage ∆ File
2
89.87
0.04% cert/cert.go
17
65.43
-11.21% hub/hub_connections_client.go
Jobs
ID Job ID Ran Files Coverage
1 18464140295.1 13 Oct 2025 11:24AM UTC 34
95.02
GitHub Action Run
Source Files on build 18464140295
  • Tree
  • List 34
  • Changed 9
  • Source Changed 9
  • Coverage Changed 9
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #18464140295
  • 09af9aac on github
  • Prev Build on dev (#17383370888)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc