zwave-js / zwave-js-ui / 18283854663

20%

push

github

fix(ui): prevent replace failed node without selecting a node (#4380)

The Nodes Manager dialog allowed users to proceed with the "replace
failed node" workflow without actually selecting a node to replace. This
resulted in users being able to click through all the steps (Action →
Node Id → Inclusion Mode) without any validation, but no actual
replacement would occur in the backend since no node ID was provided.

## Problem
In the `DialogNodesManager.vue` component, the `nextStep()` function
processed the 'replaceFailed' step without validating whether a node had
been selected (`replaceId` value). This allowed the workflow to proceed
to the inclusion mode step even when `replaceId` was `null` or
`undefined`.

## Solution
Added proper validation to prevent progression without node selection:

1. **Created `submitReplaceFailed()` validation function** that:
   - Validates that a node has been selected before proceeding
   - Shows user-friendly error messages via snackbar notifications
   - Validates numeric node IDs when manually entered
   - Only calls `nextStep()` after successful validation

2. **Updated the Next button** in the replaceFailed step to use
`submitReplaceFailed()` instead of directly calling `nextStep()`

3. **Added informative error messages**:
   - "Please select a node to replace" when no node is selected
   - "Please enter a valid node ID" for invalid numeric input

## Before/After
**Before:** Users could click "NEXT" without selecting a node and
proceed through all steps, but nothing would happen in the backend.

**After:** Users must select a valid node before they can proceed, with
clear error messages guiding them when validation fails.

The fix maintains full backward compatibility while ensuring the replace
failed node workflow requires proper node selection.

Fixes #4379.

> [!WARNING]
>
> <details>
> <summary>Firewall rules blocked me from connecting to one or more
addresses (expand for details)</summary>
>
> #### I tried to... (continued)

346 of 454 branches covered (76.21%)

Branch coverage included in aggregate %.

3959 of 20731 relevant lines covered (19.1%)

1.22 hits per line