JuliaLang / julia / 1449

77%

master: 77%

Build Type

push

buildkite

Committed by web-flow

Commit Message

force specialization of dims arguments that may be `Colon` (#59474)

In Julia, the colon (`:`, `Colon`) is a function for constructing
ranges. We have:

```julia
(:) isa Function
```

However, sadly, as an instance of punning, the same object is often also
used as an index for choosing an entire dimension.

A problem is that `Function` objects are a special case when it comes to
specializing method code for given argument types: by default a `:`
argument will get specialized as a `Function`, instead of as a `Colon`.

This change forces specialization of dims arguments in a bunch of
methods in `base/reducedim.jl`. Probably similar changes would be
beneficial across the code base, and across the ecosystem.

I believe this change will make the sysimage more resistant to
invalidation, we'll see once it builds.

Run Details

35 of 35 new or added lines in 5 files covered. (100.0%)

63 existing lines in 8 files now uncovered.

61447 of 79622 relevant lines covered (77.17%)

22539122.52 hits per line