JuliaLang / julia / 1285
77%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 296
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 70.929% (-6.0%) from 76.923%
1285

push

buildkite

web-flow 
Fix gcdx and lcm with mixed signed/unsigned arguments (#59628)

Add `gcdx(a::Signed, b::Unsigned)` and `gcdx(a::Unsigned, b::Signed)`
methods to fix #58025:
```julia
julia> gcdx(UInt16(100), Int8(-101))  # pr
(0x0001, 0xffff, 0xffff)

julia> gcdx(UInt16(100), Int8(-101))  # master, incorrect result
(0x0005, 0xf855, 0x0003)
```

Also add the equivalent methods for `lcm` to fix the systematic
`InexactError` when one argument is a negative `Signed` and the other is
any `Unsigned`:
```julia
julia> lcm(UInt16(100), Int8(-101))  # pr
0x2774

julia> lcm(UInt16(100), Int8(-101))  # master, error
ERROR: InexactError: trunc(UInt16, -101)
Stacktrace:
 [1] throw_inexacterror(func::Symbol, to::Type, val::Int8)
   @ Core ./boot.jl:866
 [2] check_sign_bit
   @ ./boot.jl:872 [inlined]
 [3] toUInt16
   @ ./boot.jl:958 [inlined]
 [4] UInt16
   @ ./boot.jl:1011 [inlined]
 [5] convert
   @ ./number.jl:7 [inlined]
 [6] _promote
   @ ./promotion.jl:379 [inlined]
 [7] promote
   @ ./promotion.jl:404 [inlined]
 [8] lcm(a::UInt16, b::Int8)
   @ Base ./intfuncs.jl:152
 [9] top-level scope
   @ REPL[62]:1
```

Inspired by
https://github.com/JuliaLang/julia/pull/59487#issuecomment-3258209203.
The difference is that the solution proposed in this PR keeps the
current correct result type for inputs such as `(::Int16, ::UInt8)`.

10 of 10 new or added lines in 1 file covered. (100.0%)

4780 existing lines in 122 files now uncovered.

50633 of 71385 relevant lines covered (70.93%)

7422080.26 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
1
90.91
 -0.48% base/abstractdict.jl
1
98.41
 -1.59% base/anyall.jl
1
51.08
 -0.72% base/fastmath.jl
1
87.56
 -0.23% base/iobuffer.jl
1
39.39
 -0.51% base/meta.jl
1
92.0
 -4.0% base/ntuple.jl
1
77.22
 -0.39% base/promotion.jl
1
66.67
 -1.67% base/refpointer.jl
1
95.13
 -0.24% base/set.jl
1
61.36
 -1.43% base/simdloop.jl
1
78.05
 -0.61% base/stacktraces.jl
1
84.41
 -0.08% Compiler/src/ssair/inlining.jl
1
67.93
 -0.06% Compiler/src/ssair/passes.jl
1
43.0
 -0.09% Compiler/src/ssair/show.jl
1
96.94
 -0.31% stdlib/InteractiveUtils/src/codeview.jl
1
81.48
 -0.93% stdlib/LibGit2/src/config.jl
1
95.45
 -2.27% stdlib/LibGit2/src/utils.jl
1
65.28
 -0.26% stdlib/Sockets/src/Sockets.jl
2
79.49
 -5.13% base/bool.jl
2
58.7
 -0.86% base/floatfuncs.jl
2
83.33
 -5.56% base/generator.jl
2
94.3
 -0.42% base/io.jl
2
90.69
 -0.98% base/reduce.jl
2
69.31
 -1.06% Compiler/src/typeutils.jl
2
84.97
 -1.31% stdlib/FileWatching/src/pidfile.jl
2
62.5
 -25.0% stdlib/LLVMLibUnwind_jll/src/LLVMLibUnwind_jll.jl
3
76.07
 -0.71% base/boot.jl
3
78.4
 -1.5% base/essentials.jl
3
85.19
 -1.33% base/indices.jl
3
96.55
 -3.45% base/linked_list.jl
3
76.07
 -0.85% base/regex.jl
3
79.06
 1.4% Compiler/src/typeinfer.jl
3
84.66
 -0.96% stdlib/LibGit2/src/LibGit2.jl
4
18.06
 -5.56% base/Base.jl
4
93.45
 -0.53% base/sort.jl
4
65.19
 -2.7% base/stat.jl
4
12.4
 -3.1% base/views.jl
4
78.88
 -2.48% stdlib/InteractiveUtils/src/InteractiveUtils.jl
4
63.16
 -10.53% stdlib/LLD_jll/src/LLD_jll.jl
5
85.97
 -0.9% base/complex.jl
5
49.64
 -0.91% base/gmp.jl
5
96.65
 -1.53% base/rational.jl
5
80.49
 -12.2% Compiler/src/reflection_interface.jl
6
63.57
 -4.65% base/Base_compiler.jl
6
85.49
 -2.53% base/cmd.jl
6
70.21
 -1.42% base/float.jl
6
80.08
 -0.79% base/intfuncs.jl
6
78.51
 -1.72% base/process.jl
6
70.66
 -1.26% base/runtime_internals.jl
6
50.0
 -43.33% stdlib/Markdown/src/IPython/IPython.jl
7
40.22
 -7.61% base/multimedia.jl
7
93.19
 -0.95% base/range.jl
7
80.8
 -3.2% base/reshapedarray.jl
7
79.46
 -6.38% base/version.jl
8
89.98
 -0.6% base/abstractarray.jl
8
26.03
 -3.55% base/terminfo.jl
8
73.6
 -0.88% Compiler/src/optimize.jl
9
93.84
 -6.16% base/accumulate.jl
9
44.75
 -2.25% base/binaryplatforms.jl
9
76.84
 -4.74% base/iostream.jl
9
87.43
 -5.14% base/threadingconstructs.jl
10
67.0
 -1.3% base/errorshow.jl
10
46.71
 -1.69% base/mpfr.jl
10
55.42
 -12.05% stdlib/InteractiveUtils/src/clipboard.jl
11
69.92
 -9.28% base/filesystem.jl
11
68.03
 -3.65% base/math.jl
11
90.14
 -7.75% stdlib/LibGit2/src/gitcredential.jl
11
13.33
 -76.14% stdlib/Markdown/src/Markdown.jl
13
30.75
 -3.74% base/client.jl
13
66.18
 -19.33% base/number.jl
13
86.43
 -6.57% base/operators.jl
13
80.56
 -3.92% stdlib/SharedArrays/src/SharedArrays.jl
15
64.52
 -12.47% base/irrationals.jl
15
65.45
 -27.27% base/linking.jl
16
82.58
 -0.58% Compiler/src/abstractinterpretation.jl
16
45.92
 -2.56% Compiler/src/typelimits.jl
16
60.78
 -31.37% stdlib/Markdown/src/parse/parse.jl
17
6.15
 -27.18% base/Terminals.jl
17
66.43
 -0.93% Compiler/src/tfuncs.jl
17
87.89
 -6.68% stdlib/LibGit2/src/types.jl
18
68.22
 -13.81% base/c.jl
18
7.89
 -47.37% stdlib/Markdown/src/GitHub/GitHub.jl
19
78.91
 -14.79% base/env.jl
19
69.01
 -11.12% base/libc.jl
20
48.03
 -6.58% base/int.jl
21
89.06
 -8.21% base/reducedim.jl
21
77.78
 -10.03% base/shell.jl
22
70.59
 -21.79% base/div.jl
22
72.73
 -11.52% base/experimental.jl
22
21.21
 -66.67% stdlib/Markdown/src/Julia/interp.jl
26
54.37
 -25.63% base/secretbuffer.jl
26
76.1
 -10.62% base/subarray.jl
27
72.32
 -1.15% base/loading.jl
30
72.67
 -20.0% base/combinatorics.jl
31
67.54
 -27.46% stdlib/Mmap/src/Mmap.jl
31
35.94
 -47.93% stdlib/Sockets/src/PipeServer.jl
32
51.75
 -22.38% base/char.jl
32
35.67
 -6.6% stdlib/FileWatching/src/FileWatching.jl
33
92.62
 -3.51% stdlib/Test/src/Test.jl
39
49.74
 -20.67% base/namedtuple.jl
40
65.02
 -17.94% base/path.jl
41
69.98
 -8.64% base/file.jl
42
54.21
 -39.31% stdlib/Markdown/src/parse/util.jl
44
69.87
 -1.97% base/show.jl
46
55.96
 -42.2% base/Enums.jl
46
53.06
 -14.99% base/util.jl
49
36.96
 -53.15% base/multinverses.jl
51
82.51
 -5.7% base/multidimensional.jl
51
76.3
 -5.98% base/stream.jl
61
34.21
 -53.51% stdlib/Markdown/src/GitHub/table.jl
68
55.73
 -13.68% base/reflection.jl
71
3.31
 -58.68% Compiler/src/validation.jl
71
13.64
 -80.68% stdlib/Markdown/src/render/plain.jl
74
61.56
 -24.1% base/tuple.jl
113
36.32
 -59.47% stdlib/Markdown/src/Common/block.jl
128
29.27
 -52.03% stdlib/LibGit2/src/callbacks.jl
167
60.6
 -29.4% base/iterators.jl
173
1.09
 -94.02% stdlib/Profile/src/Allocs.jl
525
7.94
 -84.87% stdlib/REPL/src/docview.jl
570
14.06
 -80.97% stdlib/REPL/src/REPLCompletions.jl
668
20.96
 -64.29% stdlib/REPL/src/REPL.jl
688
2.63
 -86.25% stdlib/Profile/src/Profile.jl
Jobs
ID Job ID Ran Files Coverage
1285 windows-coverage - 1285 296
70.93
Source Files on build 1285