pomerium / pomerium / 17920632366

52%

Build Type

push

github

Committed by web-flow

Commit Message

fix: race condition with mcp server handler loading (#5841)

## Summary

mcp handler is not atomically set in the constructor so race condition
can occur when a configuration is updated, trying to load the mcp
handler.

If the mcp handler has not been set, while trying to serving traffic, it
will serve a 503 Service Unavailable code.
<details>
<summary>Stack trace</summary>
<pre><code>
pomerium-1 | panic: runtime error: invalid memory address or nil pointer
dereference
pomerium-1 | [signal SIGSEGV: segmentation violation code=0x1 addr=0x0
pc=0x2868806]
pomerium-1  |
pomerium-1  | goroutine 213 [running]:
pomerium-1 |
github.com/pomerium/pomerium/internal/atomicutil.(*Value[...]).Store(...)
pomerium-1 |
/go/src/github.com/pomerium/pomerium/internal/atomicutil/value.go:34
pomerium-1 |
github.com/pomerium/pomerium/proxy.(*Proxy).OnConfigChange(0xc0009b9900,
{0x3c5c1f0, 0xc0013626c0}, 0xc000df6120)
pomerium-1 | /go/src/github.com/pomerium/pomerium/proxy/proxy.go:123
+0x106
pomerium-1 |
github.com/pomerium/pomerium/internal/autocert.(*Manager).OnConfigChange.(*ChangeDispatcher).OnConfigChange.func1({0x3c5c1f0?,
0xc0013626c0?}, {0x0?})
pomerium-1 |
/go/src/github.com/pomerium/pomerium/config/config_source.go:46 +0x22
pomerium-1 |
github.com/pomerium/pomerium/internal/events.targetListener[...].run(0xc000da7ef0?)
pomerium-1 |
/go/src/github.com/pomerium/pomerium/internal/events/target.go:148 +0x58
pomerium-1 | created by
github.com/pomerium/pomerium/internal/events.newTargetListener[...] in
goroutine 91
pomerium-1 |
/go/src/github.com/pomerium/pomerium/internal/events/target.go:127
+0x15c
pomerium-1 exited with code 2 (restarting)
</code></pre>
</details>

## Related issues

<!-- For example...
- #159
-->

## User Explanation

<!-- How would you explain this change to the user? If this
change doesn't create any user-facing changes, you can leave
this blank. If filled out, add the `docs` label -->

## Checklist

- [x] reference any related issues
- [x] update... (continued)

Coverage Stats

1 of 8 new or added lines in 2 files covered. (12.5%)

9 existing lines in 5 files now uncovered.

27021 of 50200 relevant lines covered (53.83%)

86.6 hits per line