MITLibraries / dspace-submission-composer / 17771900405

96%

main: 96%

push

github

Update domain and data persistence models for new records

Why these changes are being introduced:
* Adding an explicit 'batch creation' step to the DSC workflow
means a new method that can handle all init-level operations, such as
persisting records to DynamoDB for the first time. This allows for
simplifying some of the methods in the ItemSubmission and ItemSubmissionDB
models.

How this addresses that need:
* Refactor ItemSubmissionDB.create as a conditional save method;
instances are created by calling the ItemSubmissionDB constructor
* Add save method to domain model, which uses ItemSubmissionDB.create
to perform conditional save
* Deprecate unused ItemSubmissionDB.get_or_create method

Side effects of this change:
* This encourages the following approach:
if writing new records, use ItemSubmission.create + ItemSubmission.save
if updating existing records, set attributes on ItemSubmission() + ItemSubmission.upsert_db

TLDR: Any upserts will update and overwrite an existing record in DynamoDB.

Relevant ticket(s):
* https://mitlibraries.atlassian.net/browse/IN-1455

7 of 10 new or added lines in 2 files covered. (70.0%)

1048 of 1091 relevant lines covered (96.06%)

0.96 hits per line