iotaledger / iota / 17661826194
63%

DEFAULT BRANCH: develop
Ran
Jobs 1
Files 1420
Run time 3min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 65.664% (-0.002%) from 65.666%
17661826194

push

github

web-flow 
fix(iota): fix signing with ledger nano (#8506)

# Description of change

Fix signing with a ledger nano hardware wallet, currently fails with
`signature error: sign_secure is not supported for external type:
ledger`, broke in https://github.com/iotaledger/iota/pull/7881

## How the change has been tested

` ./run_speculos.sh` in https://github.com/iotaledger/ledger-app-iota
Normal tx:
`LEDGER_SIMULATOR=1 cargo run client pay-iota --recipients
0x<a class=hub.com/iotaledger/iota/commit/1b3669e321893ee49c387a08fc251dbfff37cd2a">1b3669e32<a href="https://github.com/iotaledger/iota/commit/75b92834a4f76619be98bd020320ec86a5c422ab">981e6c473a5b2afde19d363e
--amounts 100`

https://explorer.iota.org/txblock/BjfGrQ4JGXdEzsYZqV5gBgAUJzsddv8c6vBfYKaNqaxn?network=devnet
Sponsored tx:
```
LEDGER_SIMULATOR=1 cargo run client ptb \
--make-move-vec "<std::string::String>" "['zero', 'one', 'two']" \
--assign my_string_vec \
--sender @0x<a class="double-link" href="https://github.com/iotaledger/iota/commit/111111111504e9350e635d65cd38ccd2c029434c">111111111</a>6a3a480d8947a9ba6a15b215 \
--gas-sponsor @0x1b3669e321893ee49c387a08fc251dbfff37cd2a981e6c473a5b2afde19d363e
```

https://explorer.iota.org/txblock/BRVK4bHAcdtH5ZR4oY1vTo2q1vNvSG9CgNA68iYmeycS?network=devnet

### Release Notes

- [ ] Protocol:
- [ ] Nodes (Validators and Full nodes):
- [ ] Indexer:
- [ ] JSON-RPC:
- [ ] GraphQL:
- [x] CLI: Fix signing with ledger nano hardware wallet
- [ ] Rust SDK:
- [ ] REST API:

6 of 7 new or added lines in 3 files covered. (85.71%)

26 existing lines in 11 files now uncovered.

228709 of 348302 relevant lines covered (65.66%)

2256170.28 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
39.06
 0.0% crates/iota/src/signing.rs

Uncovered Existing Lines

Lines Coverage ∆ File
1
91.18
 0.0% crates/iota-cluster-test/src/test_case/native_transfer_test.rs
1
81.78
 -0.04% crates/iota-core/src/authority.rs
1
97.92
 -1.04% crates/iota-surfer/src/surfer_task.rs
1
85.94
 3.91% crates/iota-surfer/src/surf_strategy.rs
1
94.12
 -0.05% crates/starfish/core/src/authority_service.rs
1
81.74
 -0.06% crates/starfish/core/src/synchronizer.rs
2
54.88
 -0.45% crates/iota-core/src/storage.rs
2
95.22
 -0.87% crates/iota-http/src/lib.rs
2
93.22
 -0.15% crates/starfish/core/src/transactions_synchronizer.rs
3
79.61
 0.0% crates/starfish/core/src/network/tonic_network.rs
11
0.0
 -37.93% crates/iota-types/src/storage/error.rs
Jobs
ID Job ID Ran Files Coverage
1 nextest+simtest - 17661826194.1 1422
65.65
 GitHub Action Run
Source Files on build 17661826194