zalando / skipper / 17643000203

78%

Build Type

push

github

Committed by web-flow

Commit Message

proxy: fix timings calculation (#3603)

Refactored proxy timing measurement to track request and response phases
separately.

The previous implementation used a single stopwatch that failed to
properly handle shunt and loopback scenarios. For loopback routes,
the entire duration of subsequent loopbacks was incorrectly attributed
to response time since each loopback creates its own context.
Additionally, shunt routes never triggered the request-to-response
timer transition, which was located in makeBackendRequest and
therefore unreachable for shunt routes.

Additonally fixing another bug:
The defer statement for finishing the loopSpan was causing response
filter processing time to be incorrectly included in the loopback span
timings. This change moves the loopSpan.Finish() calls to execute
immediately after the recursive do() call completes.

---------

Signed-off-by: Aleksandr Ponimaskin <aleksandr.ponimaskin@zalando.de>

Run Details

86 of 91 new or added lines in 2 files covered. (94.51%)

2 existing lines in 1 file now uncovered.

23596 of 30397 relevant lines covered (77.63%)

89723.01 hits per line