kobotoolbox / kpi / 17628729072

81%

master: 76%

push

github

fix(migrations): partially revert #6157; avoid renaming `_reversion_version` DEV-838 (#6229)

### 👷 Description for instance maintainers

`kpi/migrations/0070_alter_assetversion_reversion_version.py` attempted
to rename the column `_reversion_version` to `_reversion_version_id` in
the table `kpi_assetversion`. Unfortunately, this can fail for existing
databases because the column was already called `_reversion_version_id`
in the first place, owing to Django's column-naming conventions for
`model.OneToOneField`.

This change uses `db_column='_reversion_version_id'` to preserve both
the Python name of the field and the PostgreSQL column name while
changing the field type from `OneToOneField` to `IntegerField`.

### 👀 Preview steps

1. Have a local development environment with an empty database
2. Check out the `release/2.025.34` branch
3. Run `scripts/migrate.sh`
4. Observe success
5. Check out `main` (the base branch for this PR)
6. Run `scripts/migrate.sh` again
7. Observe failure (`django.db.utils.ProgrammingError: column
"_reversion_version" does not exist`)
8. Reset to an empty database
9. Repeat steps (1) through (4)
10. Check out the branch for this PR (sorry, long name:
`revert-6157-beccagraber/dev-838-remove-reversion-version`)
11. Run `scripts/migrate.sh` yet again
12. Observe success :heavy_check_mark:

6861 of 10838 branches covered (63.31%)

2 of 2 new or added lines in 1 file covered. (100.0%)

26569 of 32745 relevant lines covered (81.14%)

1.6 hits per line