tari-project / tari / 17488107584
62%

DEFAULT BRANCH: development
Ran
Jobs 1
Files 701
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 61.19% (-0.03%) from 61.216%
17488107584

push

github

web-flow 
fix: false negative retrieving seed peers in connectivity manager at startup (#7474)

Description
---
This PR fixes a race condition between adding seed peers at startup and
retrieving them from the peer manager in the connectivity manager.

Motivation and Context
---
The warning message `WARN Failed to get seed peers from PeerManager,
using empty list // comms/core/src/connectivity/manager.rs:207` is a
timing issue. In this context the seed peer list is passed to the
proactive dialer to exclude them from being proactively dialed if other
connections exist. On a node with proper connectivity, seed peer dial
requests are coming through straight after.

- `2025-09-04 16:28:05.638210600 [p2p::initialization] DEBUG Adding seed
peer [PeerFlags(SEED)[0984896e74022c44] `
- `2025-09-04 16:28:05.648016500 [comms::connectivity::manager] DEBUG
ConnectivityManager started`
- `2025-09-04 16:28:05.648239900 [comms::connectivity::manager] WARN
Failed to get seed peers from PeerManager, using empty list`
- `2025-09-04 16:28:05.648850400 [comms::dht::connectivity] DEBUG Adding
5 neighbouring peer(s), removing 0 peers: 0984896e74022c442c1034852c, `
- `2025-09-04 16:28:05.648912900 [comms::connectivity::manager] TRACE
Request (11267568784269984977): DialPeer { node_id:
NodeId(0984896e74022c442c1034852c), reply_tx: None }` ...
- `2025-09-04 16:31:05.655859300 [comms::connectivity::manager] DEBUG
(5619097807157888458) Starting proactive dialing execution - current
connections: 10, target: 8`

How Has This Been Tested?
---
System-level testing

What process can a PR reviewer use to test or verify this change?
---
Code review

<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be included exactly as is in the CHANGELOG, so please think
about it carefully. -->


Breaking Changes
---

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard for... (continued)

15 of 25 new or added lines in 3 files covered. (60.0%)

37 existing lines in 9 files now uncovered.

72924 of 119176 relevant lines covered (61.19%)

300608.35 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
3
35.51
 -0.68% base_layer/p2p/src/peer_seeds.rs
3
91.84
 -0.39% comms/core/src/peer_manager/peer_storage_sql.rs
4
55.92
 0.07% comms/core/src/connectivity/manager.rs

Uncovered Existing Lines

Lines Coverage ∆ File
1
56.34
 -0.03% base_layer/core/src/chain_storage/blockchain_database.rs
1
93.89
 -0.17% base_layer/core/src/proof_of_work/monero_rx/merkle_tree.rs
1
91.54
 -0.77% base_layer/transaction_components/src/consensus/consensus_encoding/hashing.rs
1
50.19
 -0.04% base_layer/wallet/src/transaction_service/storage/sqlite_db.rs
1
90.05
 -0.25% comms/core/src/multiplexing/yamux.rs
2
81.2
 -0.3% comms/core/src/protocol/rpc/client/mod.rs
3
56.12
 -1.27% base_layer/transaction_key_manager/src/storage/sqlite_db/mod.rs
4
60.35
 -0.53% comms/dht/src/connectivity/mod.rs
23
95.61
 -3.74% base_layer/core/src/validation/block_body/test.rs
Jobs
ID Job ID Ran Files Coverage
1 17488107584.1 701
61.19
 GitHub Action Run
Source Files on build 17488107584