tari-project / tari / 17430874074
62%

DEFAULT BRANCH: development
Ran
Jobs 1
Files 701
Run time 11min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 61.216% (+0.06%) from 61.161%
17430874074

push

github

web-flow 
fix: tcp node peers discovery (#7438)

Description
---
Fixes base node connectivity issue with other peers when tor is
disabled.

Filters out peers addresses which are unsupported on host machine - this
includes:
- `onion` addresses if user has run `minotari_node` without tor.
- IPv6 addresses if host machine has no IPv6 address

This reduce amount of failed dial attempts to other peers and improves
connectivity overall.

Motivation and Context
---
Some users might not want to run tor with base node so we must ensure
it's still working without it.

How Has This Been Tested?
---
Run test cases in `peer_manager::storage::database::tests` which
validates peer filtering.
Build `minotari_node` and replaced one in the Tari Universe and I have
removed my node data directories including peer_db. I was able to pass
bootstrap and enter header sync with 6 peers on mainnet.

What process can a PR reviewer use to test or verify this change?
---
Code review, running test and same as above - run node and wait until it
get some connections.

Additional check `network.log` for base node to verify if
`minotari_node` was attempting to peers that had only onion address. It
should dial only if address is reachable.

<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be included exactly as is in the CHANGELOG, so please think
about it carefully. -->


Breaking Changes
---

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify

<!-- Does this include a breaking change? If so, include this line as a
footer -->
<!-- BREAKING CHANGE: Description what the user should do, e.g. delete a
database, resync the chain -->


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- New Features
- Introduced TransportProtocol to enumerate network address schemes and
configur... (continued)

248 of 324 new or added lines in 22 files covered. (76.54%)

3 existing lines in 2 files now uncovered.

72947 of 119163 relevant lines covered (61.22%)

229103.15 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
89.14
 0.73% comms/core/src/peer_manager/manager.rs
1
20.0
 0.0% comms/core/src/test_utils/peer_manager.rs
1
96.0
 -0.97% comms/core/src/transports/tcp.rs
2
21.5
 -0.06% base_layer/p2p/src/initialization.rs
3
0.0
 0.0% comms/core/src/test_utils/factories/mod.rs
4
59.76
 -0.97% comms/core/src/builder/mod.rs
4
40.91
 2.31% comms/core/src/transports/socks.rs
8
0.0
 0.0% comms/core/src/transports/hidden_service_transport.rs
14
0.0
 0.0% comms/core/src/transports/tcp_with_tor.rs
15
0.0
 0.0% base_layer/p2p/src/transport.rs
23
46.51
 comms/core/src/types.rs

Uncovered Existing Lines

Lines Coverage ∆ File
1
0.0
 0.0% comms/core/src/transports/tcp_with_tor.rs
2
78.49
 -0.43% base_layer/transaction_components/src/validation/aggregate_body/aggregate_body_internal_validator.rs
Jobs
ID Job ID Ran Files Coverage
1 17430874074.1 701
61.22
 GitHub Action Run
Source Files on build 17430874074