hathitrust / otis / 17332317259

98%

Build Type

push

github

Committed by web-flow

Commit Message

ETT-228 RS pilot: Register for Resource Sharing role

* encompasses ETT-220, 221, 291, 292, 293
- Add EA ticket creation capability to `JiraClient` with `JiraClient::Registration` subclass
- Create Jira tickets in the EA project and allow Jira to do the heavy lifting wrt email
- Remove `RegistrationMailer` and its associated detritus such as preview
- Address feedback on display of submission landing page UI for registrants.
  - Change page title by using new minimalistic layout and header
  - Include email and service name on both edit and show (landing and confirmation) pages
  - "Confirm registration" button styling.
  - Fix focus appearance of landing page submit button (and possibly all others)
  - Respond to feedback on content of expired registration link message
- Quality of life fixes for registration views
  - Alphabetize institutions menu by name
  - Suppress read-only fields (sent/received etc) when creating new registration
  - Remove self-referential anchor in registration landing page navbar
  - Open registration Jira links in a new tab, and display icon indicating this behavior
  - Add Jira ticket help string for registrations
  - Add Expired badge to registration index and form
- ETT-54 Find an alternative for whois-parser
 - Use the unofficial fork which still has recent activity
 - The Gemfile comment and the GitHub source should serve as reminders that we're using something a little unconventional
- Replace variations on "finished", "finalized", "received" for registration status in favor of "submitted" and "approved"
- Add `ServiceRole` class for mapping `otis_registrations.role` to outward-facing naming conventions.

Run Details

133 of 139 new or added lines in 9 files covered. (95.68%)

2 existing lines in 1 file now uncovered.

3316 of 3401 relevant lines covered (97.5%)

97.25 hits per line