#19959
89%

Ran 25 Aug 2025 11:37PM UTC

Jobs 1

Files 615

Run time 1min

Badge

Embed ▾

Committed 25 Aug 2025 11:25PM UTC coverage: 88.557% (-0.008%) from 88.565%

Build # #19959

Build Type

push

github

Committed by

web-flow

Commit Message

servlet: fix threadingTest and update lincheck (#12306)

Seems like previously it was not testing all the flows but only: the
write/flush calls are added to the queue by `runOrBuffer` because
`readyAndDrained` is initially `false`.

So,
* `isReady()` is never called
* `isReadyReturnedFalse` never set to true
* `maybeOnWritePossible()` does nothing

All that makes me think that #9917 is caused by some bugs in older
versions of llincheck, can be closed now.

A more real simulation happens if calling `onWritePossible` first via
`initialOnWritePossible`, and then it has found a race condition in
`AsyncServletOutputStreamWriterConcurrencyTest.isReady()`, if
`maybeOnWritePossible()` is executed before `return isReady`.

Additionally updated lincheck, 
* it does not need jvmArgs now 
* is compatible with java 8 again
* changed asserts from Truth to junit, as lincheck was trying to use
`com.google.common.truth.Subject.equals(Object)`

It still does not detect #12268, but might be needs more time.

Run Details

34694 of 39177 relevant lines covered (88.56%)

0.89 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	94.12	-1.18%	../netty/src/main/java/io/grpc/netty/WriteBufferingAndExceptionHandler.java
2	81.05	-2.11%	../okhttp/src/main/java/io/grpc/okhttp/ExceptionHandlingFrameWriter.java
2	93.03	-0.28%	../okhttp/src/main/java/io/grpc/okhttp/OkHttpClientTransport.java
3	91.9	-1.43%	../xds/src/main/java/io/grpc/xds/client/ControlPlaneClient.java

Jobs

ID	Job ID	Ran	Files	Coverage
1	#19959.1	25 Aug 2025 11:37PM UTC	615	88.56

grpc / grpc-java / #19959
89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #19959

grpc / grpc-java / #19959 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #19959

grpc / grpc-java / #19959
89%

README BADGES
x