berserkhmdvhb / agentic-scraper / 17221947934

87%

main: 88%

Build Type

push

github

Committed by berserkhmdvhb

Commit Message

refactor(validations): centralize and enforce stricter schema validation

- api/models.py: add `OwnerSub.from_value` trimming/validation for Auth0 subject strings
- api/schemas/user.py:
  - strip and validate `sub` field in `UserProfile`
  - add trimming validator for `name` to remove whitespace and reject empty
  - reuse centralized `validate_optional_str` where appropriate
- api/schemas/items.py: keep boundary `HttpUrl` validation, confirmed conversion to str handled internally
- api/schemas/scrape.py: ensure `id` uses UUID type, align with store-level UUID handling
- routes/scrape.py: switch to using `uuid.UUID` instead of `pydantic.UUID`, update type hints for mypy
- routes/scrape_helpers.py: no structural change, but noted possible JobStatus enum normalization
- routes/scrape_cancel_registry.py: ensure `clear_all()` also resets `_pre_canceled`
- utils/validators.py: no major changes, confirmed central validators in use, preferred Pydantic-native validation where possible
- tests:
  - update test_scrape.py to cast `UUID` → `str` for comparisons and payloads
  - update test_scrape_helpers.py to use real UUIDs instead of plain strings
  - adjust test_schemas_and_models.py:
    - handle HttpUrl normalization adding trailing slash
    - validate trimming behavior in `UserProfile.name`

All code and tests are now mypy + ruff compliant, and all tests pass after aligning schemas, validators, and test expectations.

Run Details

49 of 52 new or added lines in 6 files covered. (94.23%)

1 existing line in 1 file now uncovered.

2098 of 4482 relevant lines covered (46.81%)

3.74 hits per line