umputun / cronn / 17215432693

73%

master: 75%

Build Type

Pull #44

github

Committed by umputun

Commit Message

fix: resolve web parser reuse and SQLite locking issues

Two critical issues fixed:

1. Web UI parser reuse:
   - Web server was creating new crontab parsers on every sync instead of reusing the centralized parser from main
   - Introduced JobsProvider interface in web package (consumer-side pattern)
   - Web server now accepts parser dependency via constructor
   - Prevents resource waste and ensures consistent parser behavior

2. SQLite database locking:
   - Fixed "database is locked (SQLITE_BUSY)" errors under concurrent access
   - Added RWMutex to SQLiteStore for serialized database operations
   - Protected all DB operations (LoadJobs, SaveJobs, RecordExecution, Close)
   - Added PRAGMA busy_timeout=5000 for additional resilience

Changes:
- Added JobsProvider interface to web package with proper documentation
- Modified web.Server to use injected JobsProvider instead of creating parsers
- Added mutex-based concurrency control to SQLite operations
- Enhanced error messages with more context
- Added comprehensive test coverage for error scenarios
- Updated all tests to provide JobsProvider dependency

Pull Request Pull Request #44: fix: resolve web parser reuse and SQLite locking issues

Run Details

29 of 42 new or added lines in 3 files covered. (69.05%)

2 existing lines in 1 file now uncovered.

1916 of 2640 relevant lines covered (72.58%)

24.33 hits per line