Azure / karpenter-provider-azure / 17190141154

94%

Build Type

push

github

Committed by web-flow

Commit Message

chore: clean up skuclient (#1118)

Now that we're using the Track2 SDK for authentication, we don't need to periodically refresh the client.

We know this is true because other clients using the same credential do not hit issues with token refresh. Additionally if we examine the ServicePrincipal credential we can see that it does support refresh:
[ClientSecretCredential](https://github.com/Azure/azure-sdk-for-go/blob/main/sdk/azidentity/client_secret_credential.go#L73) calls [GetToken()](https://github.com/Azure/azure-sdk-for-go/blob/f0871996d/sdk/azidentity/confidential_client.go#L104) which calls [AcquireTokenSilent](https://github.com/AzureAD/microsoft-authentication-library-for-go/blob/main/apps/confidential/confidential.go#L589) which handles refresh/expiry at [this line](https://github.com/AzureAD/microsoft-authentication-library-for-go/blob/main/apps/internal/base/base.go#L354)

Run Details

6 of 11 new or added lines in 4 files covered. (54.55%)

2 existing lines in 1 file now uncovered.

55916 of 58532 relevant lines covered (95.53%)

0.97 hits per line