Azure / karpenter-provider-azure / 17085114701

95%

Build Type

push

github

Committed by web-flow

Commit Message

feat: introduce VnetSubnetID readiness check and wire it into the AKSNodeClass (#1075)

* feat: support subnet readiness status condition

* fix: GetFunc needs to be defaulted and called in test options

* test: adding e2e tests for subnet readiness

* fix: removing SubnetFull and leaving for future implementation

* test: validating Subnet readiness condition in e2e properly

* fix: tests need v1alpha2

* ci: gofmt -w -s pkg/fake/subnetsapi.go pkg/test/environment.go

* test: using real subnet id when testing drift instead of a fake one

* test: adding subnet e2es to matrix

* refactor: scope down azure client usage

* refactor: tests should use requeueAfter intervals

* refactor: refactoring subnet reasons to be unready rather than ready

* chore: adding better doc comment to VnetSubnetIDComponents function

* refactor: adding clarity to the error messages and not parsing basic err.Error()

* test: removing test case that can no longer work with proper subnet validation implemented

* fix: removing import

* fix: updating ci checks

* ci: lint

* nit: spelling

* test: add comprehensive subnet validation tests Add e2e tests for subnet ID validation, unit tests for IsSameVNET, and refactor controller tests to use standard patterns

* refactor: cleanup subnet default GetFunc()

* fix: ci

* fix: adding matching reasons, and return reconcile result on failure

* fix: updating tests

* fix: updating the not found check

* fix: ci

* fix: asserting interface for subnet api

* refactor: updating the error messages ran e2e suite locally
Ran 7 of 7 Specs in 444.231 seconds
SUCCESS! -- 7 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestSubnet (444.23s)
PASS

* Update pkg/controllers/nodeclass/status/subnet.go

* refactor: describe table for IsSameVNET()

* fix: ci

* fix: comments

* fix: returning nil for the error interface so we dont do any sort of backoff on the controller

* fixing ordering and checking root condition readiness too

* fix

------... (continued)

Coverage Stats

74 of 103 new or added lines in 9 files covered. (71.84%)

45 existing lines in 6 files now uncovered.

55923 of 58583 relevant lines covered (95.46%)

0.96 hits per line