Qiskit / qiskit / 17157397097

88%

Build Type

push

github

Committed by web-flow

Commit Message

Add interoperation between `TranspileLayout` and `PropertySet` (#14826)

* Add interoperation between `TranspileLayout` and `PropertySet`

This adds a constructor and a "destructor" to `TranspileLayout` to
cleanly centralise how the current ad-hoc `PropertySet` properties are
combined into a `TranspileLayout`, and lets them be written back out
again.  This lets passes in the middle of an execution pipeline
construct a complete `TranspileLayout` structure, based on the current
state.

This is a step along the road to centralising `TranspileLayout` into a
core part of the IR; we can now add methods to it, write transpiler
passes against `TranspileLayout`, and start transitioning the logic,
without breaking backwards compatibility.  The idea is that passes will
opt in to creating a `TranspileLayout`, mutate it, then write it back
out again.  In the future, we can have the pass manager itself manage
legacy passes by extracting the `TranspileLayout` into the `PropertySet`
before executing a legacy pass.

* Remove unused import

* Be more commital about 3.0

* Make comment more explicit about state

* Handle case of `final_layout` without `layout`

If a virtual-permutation setting pass uses
`TranspileLayout.write_into_property_set` to normalise its virtual
permutation into a final layout, we would have subsequently failed to
detect the permutation if the initial layout was (validly) reset to
`None`.  This corrects the logic.

Run Details

47 of 47 new or added lines in 2 files covered. (100.0%)

13 existing lines in 4 files now uncovered.

89843 of 101599 relevant lines covered (88.43%)

496379.11 hits per line