Qiskit / qiskit / 17157549394

88%

Build Type

push

github

Committed by web-flow

Commit Message

Add Split2qUnitaries to C API (#14720)

* Add Split2qUnitaries to C API

This commit adds a standalone transpiler pass function to the C API for
running the Split2qUnitaries transpiler pass. This pass mutates the dag
in place if there is no swap splitting that occurs (either by user
option or because there are no applicable gates) or returns a new dag
with a permutation. This result is encapsulated in a
Split2qUnitariesResult struct that contains the circuit and the
permutation.

One small change was needed to the dag circuit and the rust code of the
pass to enable running it without python. A py token was used for
updating the instruction cache when splitting instructions. This was
mostly a leftover from when unitary gate was a PyGate where this
mattered, but now there isn't anything to prepopulate. But also it
wasn't ever necessary in the case of a python defined operation it would
do the ref count update implicitly and populate the cache on the first
access. This commit removes the python usage for this which simplifies
the code and also enables running this pass from standalone C.

Fixes #14448

* Pivot to returning TranspileLayout instead of custom return type

* Fix memory leak in test

* Add missing newlines from error strings

* Apply suggestions from code review

Co-authored-by: Raynel Sanchez <87539502+raynelfss@users.noreply.github.com>

* Fix docstring example

* Fix error message on internal pass failure

* Add missing QkTranspileLayout free in failure mode where it shouldn't exist

* Fix failure message in test where permutation doesn't exist and is expected

---------

Co-authored-by: Raynel Sanchez <87539502+raynelfss@users.noreply.github.com>

Run Details

32 of 35 new or added lines in 3 files covered. (91.43%)

24 existing lines in 4 files now uncovered.

89862 of 101618 relevant lines covered (88.43%)

496338.97 hits per line