|
Ran
|
Jobs
1
|
Files
1191
|
Run time
3min
|
Badge
README BADGES
|
push
github
feat: support different etags per environment (#10512) ## About the changes This PR introduces environment-specific etags. This way clients will not react by updating features when there are changes in environments the SDK doesn't care about. ## Details There's a bit of scouting work (please don't make me split this :pray:) and other details are in comments, but the most relevant for the lazy ones: - Important **decision** on how we detect changes, unifying polling and delta: https://github.com/Unleash/unleash/pull/10512#discussion_r2285677129 - **Decision** on how we update revision id per environment: https://github.com/Unleash/unleash/pull/10512#discussion_r2291888401 - and how we do initial fetch on the read path: https://github.com/Unleash/unleash/pull/10512#discussion_r2291884777 - The singleton pattern that gave me **nightmares**: https://github.com/Unleash/unleash/pull/10512#discussion_r2291848934 - **Do we still have ALL_ENVS tokens?** https://github.com/Unleash/unleash/pull/10512#discussion_r2291913249 ## Feature flag To control the rollout introduced `etagByEnv` feature: [0da567d](https://github.com/Unleash/unleash/pull/10512/commits/0da567dd9)
7140 of 7191 branches covered (99.29%)
73 of 77 new or added lines in 6 files covered. (94.81%)
6 existing lines in 1 file now uncovered.67541 of 73792 relevant lines covered (91.53%)
443.93 hits per line
| Lines | Coverage | ∆ | File |
|---|---|---|---|
| 4 |
83.08 |
0.0% | src/lib/app.ts |
| Lines | Coverage | ∆ | File |
|---|---|---|---|
| 6 |
46.9 |
-1.03% | src/lib/services/email-service.ts |
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 1 | 17156770733.1 | 1191 |
91.53 |
GitHub Action Run |
| Coverage | ∆ | File | Lines | Relevant | Covered | Missed | Hits/Line | Branch Hits | Branch Misses |
|---|