Qiskit / qiskit / 17154949285

88%

Build Type

push

github

Committed by web-flow

Commit Message

Rename variable mapper Target enum to SwitchTarget (#14935)

* Rename variable mapper Target enum to ControlFlowTarget

For better or worse we're using cbindgen to generate the C headers and
it does basically a flat search on the entire rust code base for symbol
names when trying to extract details for types exposed across the C FFI.
This means if there are any name overlaps, regardless of whether they're
namespaced or set to private visibility will likely confuse cbindgen and
create an incorrect C header file. The latest instance of this is the
`Target` name. In the C API we export `qiskit_transpiler::target::Target`
as that is the public facing representation of the compilation target to
C, however there was also a `qiskit_circuit::variable_mapper::Target`
enum which is internally used in the circuit crate to represent the
target type of a control flow operation. cbindgen was getting these
confused and exporting the docstring from the enum and not the actual
user facing struct. This commit corrects for this shortcoming by renaming
`qiskit_circuit::variable_mapper::Target` to `ControlFlowTarget` so
there is no longer a name collision and cbindgen will pick the correct
type to use for generating the header.

* Switch from `ControlFlowTarget` to `SwitchTarget`

Run Details

7 of 12 new or added lines in 1 file covered. (58.33%)

23 existing lines in 3 files now uncovered.

89817 of 101584 relevant lines covered (88.42%)

498266.81 hits per line