Ouranosinc / xclim / 17135170843
92%

DEFAULT BRANCH: main
Ran
Jobs 8
Files 59
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 92.27%. First build
17135170843

push

github

web-flow 
Fix tests relying on inexact pint 0.24 and avoid numbagg-introduced noise in standardized index testing (#2228)

<!--Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [ ] This PR addresses an already opened issue (for bug fixes /
features)
    - This PR fixes #xyz
- [x] Tests for the changes have been added (for bug fixes / features)
- [x] (If applicable) Documentation has been added / updated (for bug
fixes / features)
- [x] CHANGELOG.rst has been updated (with summary of main changes)
- [x] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added

### What kind of change does this PR introduce?

* Fix tests that were relying on inexact conversions from pint 0.24.4
+ `pr` data flags where strangely inputting an array full of 1 mm/d and
then asserting that the "eq_1_repeating_for_10_or_more_days" tests was
_false_. Fixed to True, skipped with older pint.
+ Similarly, the other test had hardcoded inexact kg m-2 s-1 values that
converted to 1 in pint 0.24.4, but not pint 0.25.
+ The dry spell tests had a day where the precip amount was just under 3
mm because of inexact conversion, but in theory it should have been 3
(which it is in new pint). The threshold was modified to be less
sensitive.
* Avoid `numbagg` for standardized indices. It seems the use (or not) of
numbagg changes only slightly the rolling mean values, but this change
is enough to throw off the mle-fit-based result of the test. I create a
simple fixture that simply deactivates the usage of `numbagg` in the
tests where it is added as an arg.

### Does this PR introduce a breaking change?
No.


### Other information:

7747 of 8396 relevant lines covered (92.27%)

8.09 hits per line

Jobs
ID Job ID Ran Files Coverage
1 run-3.11-ubuntu-latest-preliminary - 17135170843.1 59
88.63
 GitHub Action Run
2 run-3.11-ubuntu-latest-standard - 17135170843.2 59
88.92
 GitHub Action Run
3 run-3.11-ubuntu-latest-py311-coverage-extras-sbck-offline-prefetch - 17135170843.3 59
88.79
 GitHub Action Run
4 run-{{ matrix.python-version }}-conda - 17135170843.4 58
92.13
 GitHub Action Run
5 run-3.12-ubuntu-latest-standard - 17135170843.5 59
88.83
 GitHub Action Run
6 run-3.11-macos-latest-py311-coverage-extras-lmoments - 17135170843.6 59
92.07
 GitHub Action Run
7 run-3.12-windows-latest-py312-coverage-prefetch - 17135170843.7 59
88.36
 GitHub Action Run
8 run-3.10-ubuntu-latest-standard - 17135170843.8 59
88.83
 GitHub Action Run
Source Files on build 17135170843