JackAshwell11 / Hades / 17012457186

73%

Build Type

push

github

Committed by JackAshwell11

Commit Message

Fixed a bug where the player sprite would not appear, but the user would still be able to control the game. This occurred because the game engine was initialised (which created the player game object) before the game scene was able to be initialised, causing the `on_game_object_creation()` callback to not be called. This was fixed by lazily loading the game engine in the model so it would be called during access in `HadesWindow.setup()`.

This also allowed other recurring problems to be fixed, such as relying on a `PythonSprite` for mapping game object IDs to sprite objects, which has now been fixed by using a `sprites` dict in `HadesModel` removing the Python dependency in the C++ library as well.

Run Details

31 of 37 new or added lines in 8 files covered. (83.78%)

49 existing lines in 13 files now uncovered.

2165 of 2315 relevant lines covered (93.52%)

20669.7 hits per line