hydrologie / xhydro / 16996810015

92%

push

github

Update Hydrotel (#331)

<!-- Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [x] This PR addresses an already opened issue (for bug fixes /
features)
  - This PR fixes #xyz
- [x] (If applicable) Documentation has been added / updated (for bug
fixes / features).
- [x] If changes affect the GIS, Raven Modelling, Extremes.jl or Use
Case Example notebooks, they have been re-run (ReadTheDocs will not
update these).
- [x] If text has changed, ``make initialize-translations`` /
``make-translations.bat`` has been run and translations have been
updated.
- [x] (If applicable) Tests have been added.
- [x] CHANGELOG.rst has been updated (with summary of main changes).
- [x] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added.

### What kind of change does this PR introduce?

* Corrige un bug où le fichier `simulation.csv` devrait en fait avoir un
nom dynamique.
* Retire `use_defaults` d'Hydrotel, puisque cela pourrait porter à
confusion et être difficile à maintenir à travers différentes versions
d'Hydrotel.
* Retire la plupart des `_basic_checks`, puisque ces vérifications sont
déjà faites par Hydrotel ou couvertes par la fonction `format_inputs`.
* Ajoute la possibilité d'inclure des options supplémentaires lors de
l'exécution d'Hydrotel.

### Does this PR introduce a breaking change?

* Oui si quelqu'un utilisait `use_defaults`, mais je ne crois pas que
c'était le cas.
* `station_id` est maintenant `subbasin_id`


### Other information:

38 of 39 new or added lines in 3 files covered. (97.44%)

2829 of 3047 relevant lines covered (92.85%)

4.09 hits per line