16939386794
81%
master: 76%

Ran 13 Aug 2025 02:31PM UTC

Jobs 2

Files 665

Run time 2min

Badge

Embed ▾

Committed 13 Aug 2025 01:54PM UTC coverage: 81.417% (-0.007%) from 81.424%

Build # 16939386794

Build Type

push

github

Committed by

web-flow

Commit Message

fix(permissions): improve UI in Sharing Form DEV-863 (#6056)

### 📣 Summary

Fix minor issue of "Act on submissions only from specific users (…)" not
mentioning all the users from permissions.

### 💭 Notes

This is the outcome of investigation work for the DEV-808 UI bug.

Changes here:
- Cleaned up few Sharing Form related constants
- Added few comments
- Added new test for debugging the UI bug
- Fix `getPartialByUsersFilterList` to work with recent-ish Backend
change that makes it possible to have multiple "by users" filters (i.e.
`filters: [{ _submitted_by: { $in: ['kate', 'joshua'] } }]` vs `filters:
[{ _submitted_by: 'kate' }, { _submitted_by: 'joshua' }]`

### 👀 Preview steps

1. ℹ️ have an account and a project
2. go to Project → Settings → Sharing
3. add new permissions
   - set "View submissions only from specific users" to "joe"
   - set "Edit submissions only from specific users" to "bob"
4. save permissions
5. 🔴 [on main] notice that the list says "Act on submissions only from
specific users (bob)" (missing "joe")
6. 🟢 [on PR] notice that the list says "Act on submissions only from
specific users (bob, joe)"

Run Details

6439 of 10121 branches covered (63.62%)

24426 of 30001 relevant lines covered (81.42%)

1.6 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	87.32	-1.41%	kobo/apps/organizations/admin/organization.py
1	84.21	-5.26%	kpi/urls/__init__.py
1	93.62	-2.13%	kpi/utils/django_orm_helper.py
2	93.53	-1.0%	kobo/apps/mass_emails/tasks.py
3	63.64	-18.18%	kobo/apps/accounts/utils.py
3	82.42	-1.82%	kobo/apps/organizations/models.py
3	86.67	-10.0%	kobo/apps/organizations/utils.py
3	90.52	-2.59%	kpi/views/environment.py
4	83.33	-8.33%	kobo/apps/accounts/mfa/models.py
7	0.0	-100.0%	kobo/apps/stripe/apps.py
7	81.16	-10.14%	kobo/apps/trash_bin/tasks/attachment.py
8	0.0	-100.0%	kobo/apps/stripe/urls.py
10	84.04	-10.64%	kobo/apps/subsequences/api_view.py
11	86.69	-2.15%	kobo/apps/openrosa/libs/utils/logger_tools.py
12	35.0	-60.0%	kobo/apps/stripe/utils/import_management.py
12	0.0	-75.0%	kobo/apps/stripe/utils/view_utils.py
15	0.0	-100.0%	kobo/apps/stripe/tasks.py
19	0.0	-65.52%	kobo/apps/stripe/admin.py
23	0.0	-92.0%	kobo/apps/stripe/signals.py
24	75.49	-23.53%	kpi/utils/usage_calculator.py
25	47.89	-33.8%	kobo/apps/mass_emails/user_queries.py
26	27.78	-72.22%	kobo/apps/stripe/utils/limit_enforcement.py
27	57.97	-37.68%	kobo/apps/trackers/utils.py
64	0.0	-98.46%	kobo/apps/stripe/serializers.py
64	21.43	-76.19%	kobo/apps/stripe/utils/billing_dates.py
86	26.5	-73.5%	kobo/apps/stripe/utils/subscription_limits.py
111	0.0	-90.98%	kobo/apps/stripe/models.py
154	0.0	-95.65%	kobo/apps/stripe/views.py

Jobs

ID	Job ID	Ran	Files	Coverage
1	16939386794.1	13 Aug 2025 02:31PM UTC	665	79.0
2	16939386794.2	13 Aug 2025 02:36PM UTC	665	81.4

kobotoolbox / kpi / 16939386794
81%
master: 76%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 16939386794

kobotoolbox / kpi / 16939386794 81% master: 76%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 16939386794

kobotoolbox / kpi / 16939386794
81%
master: 76%

README BADGES
x