MITLibraries / dspace-submission-composer / 16831668410

95%

push

github

In 1357 finalize refactor (#191)

* Add ItemSubmission._exceeded_retry_threshold

* Add ItemSubmission._exceeded_retry_threshold method and call in ready_to_submit method

* Update result_message fixtures

* Rename result_message_body > result_message_body_success
* Add result_message_body_error fixture

* Remove process_result_messages method and corresponding unit tests

* Refactor finalize CLI command

Why these changes are being introduced:
* Refactoring functionality called by the finalize CLI command to take advantage of the updated ItemSubmission class

How this addresses that need:
* Refactor finalize_items method and add corresponding unit tests for various scenarios
* Add validate_result_message method to encapsulate SQS message validation logic and corresponding unit test
* Update finalize CLI test to better utilize the mocked_item_submission_db fixture

Side effects of this change:
* None

Relevant ticket(s):
* https://mitlibraries.atlassian.net/browse/IN-1357

* Updates based on discussion in PR # 191

* Add DSSResultMessage class for parsing and storing SQS result message data
* Update finalize_items to use DSSResultMessage class
* Add finalize_items unit test for exception handling
* Remove validate_result_message, _parse_result_message_attrs, _parse_result_message_body methods as the DSSResultMessage class performs all validation

* Further updates based on discussion in PR # 191

* Set unique variable names to avoid mypy error
* Update code block triggered by lack of result_message to simply continue and update corresponding unit test
* Shift workflow_specific_processing call to end of finalize_items method

* Update outdated comment

65 of 66 new or added lines in 2 files covered. (98.48%)

955 of 987 relevant lines covered (96.76%)

0.97 hits per line