iotaledger / iota / 16765282075

65%

Build Type

push

github

Committed by web-flow

Commit Message

fix(framework): when setting a candidate commission rate also set the next epoch commission rate, else it will be reset after the candidate joins the active set (#8103)

# Description of change

If a candidate validator updates the commission rate using the
`set_candidate_validator_commission_rate` the framework was only
updating the current commission rate but kept the "next epoch"
commission rate untouched. This meant that as soon as the candidate
validator joined the network and the epoch advanced, the system would
reset the commission rate to the value of the "next epoch".

This fix updates both fields correctly.

Note: this PR should be merged, not squashed due to it updating the
framework snapshots.

## Links to any relevant issues

Be sure to reference any related issues by adding `fixes #(issue)`.

## How the change has been tested

- [ ] Basic tests (linting, compilation, formatting, unit/integration
tests)
- [ ] Patch-specific tests (correctness, functionality coverage)
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have checked that new and existing unit tests pass locally with
my changes

### Release Notes

- [x] Protocol: Properly update a validator commission rate when
`set_candidate_validator_commission_rate` is called.
- [ ] Nodes (Validators and Full nodes):
- [ ] Indexer:
- [ ] JSON-RPC:
- [ ] GraphQL:
- [ ] CLI:
- [ ] Rust SDK:
- [ ] REST API:

Run Details

8 of 8 new or added lines in 1 file covered. (100.0%)

134 existing lines in 12 files now uncovered.

235374 of 359180 relevant lines covered (65.53%)

2339343.1 hits per line