biocore / kl-metapool / 16751339665

92%

master: 93%

Build Type

push

github

Committed by web-flow

Commit Message

Replicate fix 2 (#320)

* rename tests for clarity, move mp_string tests into appropriate test file

* rename columns so orig_name exists and optional columns are clearly indicated

* clarify how to input source plate info when using plate replication

* clarify error if contains_replicates not in Bioinformatics section

* break out katharoseq no-state-change test as separate function

* Refactor PlateReplication to make internal stuff private, rename for clarity, add comments, add `unmake_replicates`. Refactor prep and sample_sheet to use `unmake_replicates` instead of duplicating code

* lint

* lint

* change default value for katharoseq_dir

* add shared interface between PlateReplication and PlateRemapper

* add PlateReplication get_384_well_location and unmake_replicates tests, do cleanup

* test ErrorMessage strings not objects for ease of debugging

* add unmake_replicates test files

* extend test helper functions, standardize test file name

* katharoseq test rewrite

* add roundtrip tests, update test files accordingly

* partially address #305

* add validation to make_sample_sheet

* lint

* lint

* extend v100 tests with replicates, standardize test file names

* add remapper to v100 to rename Library Well in plate df to destination_well_384 in sample sheet

* refactor PlateReplication setting of contains_replicates, specification of dest col name, and variable naming (for clarity)

* lint

* centralized code to determine if a df contains replicates for both pre-preps and sample sheets

* remove TODO

* changed code to look for *string* True/False values of contains_replicates

* address code review comments

Run Details

466 of 474 new or added lines in 9 files covered. (98.31%)

2 existing lines in 2 files now uncovered.

6495 of 7023 relevant lines covered (92.48%)

0.92 hits per line