agama-project / agama / 16721753934

74%

Build Type

push

github

Committed by web-flow

Commit Message

fix(rust) Do not return Err when a connection activation fails during writing but log the error (#2629)

## Problem

Currently the add_or_update_connection client method not only
add_or_update a connection in NetworkManager but it also tries to
activate or deactivate it based on the status property. The problem is
that the activation could fail in some situations like:

  - The interface bind to the connection is not present.
- The interface bind to the connection is already applying other
connection.
  - In case of Wireless, wireless could be disabled by hardware.
  
.... and other cases.

When this happen it returns with an error and the write operation does a
rollback to the checkpoint created before starting with the write.

-
https://trello.com/c/c7HAWvBz/5020-1245548-modifying-a-network-connection-binding-settings-does-not-apply-the-changes-to-the-active-connection

## Solution

- When the activation or deactivation of a connection return an error it
will be just logged in order to finish with the write of the
connections.
- Before activating a connection, if it is bind to an specific interface
which is applying a different connection then the device will be
disconnected in order to be able to activate the latest one. Example,
the default connection created by dracut which could be applied to
multiple-connections.

## Testing

- Tested manually
```bash
suse@vikingo:~$ cat test.json 
{
  "network": {
    "connections": [
      {
        "id": "br0",
        "interface": "br0",
        "status": "up",
        "persistent": true,
        "bridge": {
          "ports": ["eth0"],
          "stp": false
        }
      }
    ]
  }
}

suse@vikingo:~$ agama config load < test.json 
✓ The profile is valid.

# Logs from agama-web-server
2025-07-30T13:04:07.370000Z  INFO agama_network::nm::adapter: agama-network/src/nm/adapter.rs:152: No change detected for connection Sarambeque (cb47c266-d391-409d-97a2-12cbb311aca6)                             
2025-07-30... (continued)

Run Details

2135 of 3884 branches covered (54.97%)

Branch coverage included in aggregate %.

0 of 42 new or added lines in 2 files covered. (0.0%)

3 existing lines in 1 file now uncovered.

24842 of 38202 relevant lines covered (65.03%)

49.06 hits per line