IGVF-DACC / igvf-ui / #6070

100%

main: 100%

push

IGVF-2909 Use conditional length tests for all array properties in objects (#859)

* Convert all the pages to use a basic existence test for submitted array properties, and a conditional length test for calculated array properties.
* Update common-data-items.js to have submitted array elements just test their existence rather than both that and their length.
* Update file graph code to only test for existence for `aliases` and `derived_from` instead of existence and length.
* Update list renderers for the new method of accessing submitted and calculated array properties.
* Make the same adjustments to relevant files in components.
* Update file graph to treat quality_metrics for a file as a calculated array property. Remove an impossible case from a list-renderer Jest test.
* Fix incorrect calculated array handling in sample-table.js.
* Use conditional length checks for all array properties, both submitted and calculated. This only covers the submitted ones I changed to truth checks in earlier commits. I still need to check for any truthy checks that existed before this branch.
* Change last array properties to `?.length > 0` tests.
* Correct stray incidences of not testing submitted array properties correctly.

1553 of 1553 branches covered (100.0%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 2 files covered. (100.0%)

3482 of 3482 relevant lines covered (100.0%)

18.45 hits per line