MITLibraries / dspace-submission-composer / 16629981396

95%

push

github

In 1356 update submit (#189)

* IN-1356-update-submit

Why these changes are being introduced:
* Further changes are needed for the submit command to properly take advantage of the updated ItemSubmission class

How this addresses that need:
* Shift create_dspace_metadata and validate_dspace_metadata methods from base Workflow class to ItemSubmission class
* Shift corresponding unit tests to ItemSubmission class unit test module

Side effects of this change:
* None

Relevant ticket(s):
* https://mitlibraries.atlassian.net/browse/IN-1356

* Refactor Workflow.item_submissions_iter

* Refactor item_submissions_iter to use ItemSubmissionDB.get_batch_items method
* Remove missing row unit test as it is no longer possible to trigger this scenario

* Updates based on discussion in PR # 189

* Reorder DynamoDB attributes to match order of ItemSubmission class
* Add DSpaceMetadataUploadError and SQSMessageSendError custom exception and refactor ItemSubmission.upload_dspace_metadata and send_submission_message methods to use them
* Create wrapper method ItemSubmission.prepare_dspace_metadata to encapsulate all DSpace metadata functionality
* Refactor ItemSubmission.create_dspace_metadata  and validate_dspace_metadata to align with upload_dspace_metadata's saving to self attribute
* Remove Workflow.item_submission_iter method and shift functionality to Workflow.submit_items
* Shift ItemSubmission.ready_to_submit call before metadata creation in Workflow.submit_items
* Add DynamoDB updates to exception block in Workflow.submit_items to take advantage of new custom
* Update unit tests to account for new functionality

* Remove unnecessary method

* Remove ItemSubmission.get_batch_items method and corresponding unit test in favor of query method

60 of 60 new or added lines in 4 files covered. (100.0%)

928 of 955 relevant lines covered (97.17%)

0.97 hits per line