MITLibraries / dspace-submission-composer / 16525914544

95%

push

github

IN-1354-itemsubmission-class-update (#187)

* IN-1354-itemsubmission-class-update

Why these changes are being introduced:
* Adding functionality to the ItemSubmission class to support a significant refactor of the application

How this addresses that need:
* Add new attributes to ItemSubmission class
* Add populate_from_db, update_db, and ready_to_submit methods to ItemSubmission class and corresponding unit tests
* Update Workflow.submit_items method to use ItemSubmission.populate_from_db and ItemSubmission.ready_to_submit
* Remove Workflow.allow_submission method and corresponding unit testsas it is replaced by ItemSubmission.ready_to_submit
* Rename test_workflow.py > test_workflow_base.py
* Update item_submission_instance fixture to capture new init attributes
* Remove last_submission_message attribute from DynamoDB model as it is not used

Side effects of this change:
* None

Relevant ticket(s):
* https://mitlibraries.atlassian.net/browse/IN-1354

* Update ItemSubmissionDB model

* Add collection_handle attribute
* Add get_batch_items class method and corresponding unit test

* Update ItemSubmission class

* Organize attributes in persisted and processing categories
* Add from_metadata, from_batch_id_and_item_identifier, and from_db class methods and corresponding unit tests
* Shift exception handling from Workflow.submit_items into ItemSubmission.upload_dspace_metadata and ItemSubmission.send_submission_message and add corresponding unit tests

* Update Base Workflow

* Shift submission_summary to attribute for easier access by multiple methods
* Update submit_items method to take advantage of the updated ItemSubmission class attributes and methods
* Update item_submission_iter to take advantage of the updated ItemSubmission class attributes and methods
* Update unit tests for more robust testing

* Updates based on discussion in PR #187

* Remove last_submission_message attribute from ItemSubmissionDB
* Update ItemSubmission.from_metadata to p... (continued)

101 of 101 new or added lines in 3 files covered. (100.0%)

938 of 965 relevant lines covered (97.2%)

0.97 hits per line