NVIDIA / holodeck / 16627726469

11%

main: 22%

push

github

feat: replace bash cleanup script with native Go implementation

Migrate AWS VPC cleanup functionality from bash script to a native Go
package and CLI command, improving maintainability, error handling, and
integration with the holodeck toolchain.

BREAKING CHANGE: The cleanup functionality is now available through
`holodeck cleanup` command instead of scripts/awscleanup.sh

Changes:
- Add pkg/cleanup package with comprehensive AWS resource deletion
  - Handles EC2 instances, security groups, subnets, route tables, IGWs
  - Includes GitHub job status checking via API
  - Implements retry logic for VPC deletion (3 attempts, 30s delay)
  - Better error handling with partial failure support

- Add `holodeck cleanup` CLI command
  - Accepts multiple VPC IDs in a single invocation
  - --region flag for AWS region specification
  - --force flag to skip GitHub job status checks
  - Comprehensive help documentation

- Update periodic GitHub workflow
  - Now uses `holodeck cleanup` instead of bash script
  - Builds Go binary as part of the workflow
  - Better error handling and logging
  - Handles multiple VPCs more efficiently

- Add documentation
  - docs/commands/cleanup.md with detailed usage examples
  - Updated README.md with cleanup examples
  - Updated command reference documentation

- Add deprecation warning to scripts/awscleanup.sh
  - Script still functional but warns users to migrate
  - Can be removed in a future release

Benefits:
- Type safety and better error handling
- Consistent with other holodeck commands
- Easier to test and maintain
- More efficient handling of multiple VPCs
- Better integration with CI/CD pipelines

Fixes: Improves reliability of periodic cleanup jobs
Refs: Migration from bash to Go for better maintainability

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

7 of 355 new or added lines in 1 file covered. (1.97%)

268 of 2183 relevant lines covered (12.28%)

0.14 hits per line