drakenclimber / libcgroup / 16602408173

56%

main: 56%

Build Type

push

github

Committed by drakenclimber

Commit Message

cgclassify: Fix clang warnings

Fix the following clang warnings by shrinking the scan size from 4096 to
4095 to allow room for the null terminating character.

	cgclassify.c:334:47: warning: 'sscanf' may overflow; destination buffer
	in argument 4 has size 4096, but the corresponding specifier may require
	size 4097 [-Wfortify-source]
	  334 |                         ret = sscanf(buffer, "%d::%4096s\n",
	&idx, cgrp_name);
	      |
	^
	cgclassify.c:336:63: warning: 'sscanf' may overflow; destination buffer
	in argument 5 has size 4096, but the corresponding specifier may require
	size 4097 [-Wfortify-source]
	  336 |                         ret = sscanf(buffer,
	"%d:%[^:]:%4096s\n", &idx, ctrl_name, cgrp_name);
	      |
	^
	cgclassify.c:497:40: warning: 'sscanf' may overflow; destination buffer
	in argument 3 has size 4096, but the corresponding specifier may require
	size 4097 [-Wfortify-source]
	  497 |                 ret = sscanf(buffer, "%*s %4096s\n", cgrp_path);
	      |                                                      ^

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

Run Details

1 of 3 new or added lines in 1 file covered. (33.33%)

465 existing lines in 2 files now uncovered.

5591 of 9956 relevant lines covered (56.16%)

407.63 hits per line