vortex-data / vortex / 16597359372

88%

Build Type

push

github

Committed by web-flow

Commit Message

[chore] conformance testing for TakeFn (#4043)

FLUP to #4041 

⏺ Summary of Take Conformance Test Implementation

I successfully implemented a comprehensive conformance test suite for
the take compute function across the Vortex codebase, following the
pattern
  established for the filter conformance tests.

  1. Created Take Conformance Test Harness

- Added /vortex-array/src/compute/conformance/take.rs with a flexible
test suite
  - Implemented test functions covering various scenarios:
    - test_take_all - Take all elements in order
    - test_take_none - Take no elements (empty indices)
    - test_take_selective - Take every other element
    - test_take_first_and_last - Take first and last elements
    - test_take_with_nullable_indices - Take with nullable indices
    - test_take_repeated_indices - Take same element multiple times
    - test_empty_indices - Take with empty indices array

  2. Enhanced Test Harness with Additional Edge Cases

  Added more comprehensive test scenarios:
  - test_take_reverse - Take elements in reverse order
  - test_take_single_middle - Take single element from middle
  - test_take_random_unsorted - Take with pseudo-random pattern
  - test_take_contiguous_range - Take contiguous range from middle
  - test_take_mixed_repeated - Take with mixed repeated indices
  - test_take_large_indices - Stress test with large number of indices

  3. Added Take Conformance Tests to Array Types

  Successfully added take conformance tests to:
  - PrimitiveArray - Basic numeric arrays
  - BoolArray - Boolean arrays
  - VarBinArray - Variable-length binary arrays
  - VarBinViewArray - Variable-length binary view arrays
  - ChunkedArray - Chunked arrays
  - NullArray - Arrays of all null values
  - ConstantArray - Arrays with constant values
  - ExtensionArray - Extension arrays (fixed dtype sync issue)
  - StructArray - Struct arrays including nested structs
  - ListArray - List arrays with various configurations
  - DecimalArray - D... (continued)

Run Details

373 of 390 new or added lines in 10 files covered. (95.64%)

8 existing lines in 1 file now uncovered.

45233 of 54693 relevant lines covered (82.7%)

184886.37 hits per line