16587034244
83%

Ran 29 Jul 2025 05:55AM UTC

Jobs 1

Files 59

Run time 1min

Badge

Embed ▾

Committed 28 Jul 2025 02:47PM UTC coverage: 85.901% (+0.1%) from 85.756%

Build # 16587034244

Build Type

push

github

Committed by

web-flow

Commit Message

[IMPROVED] Mark consumer active before processing acks (#7107)

Fixes a small race condition where the last ack for a message could be
processed in `o.processAck(..)`, the inactivity timer could then hit and
lock the consumer before we're able to `o.suppressDeletion()` (which
also requires the lock).

Calling `o.suppressDeletion()` first means we can't race with the
inactivity timer deleting the consumer due to acking the last pending
message, when the last message pull request was longer ago than the
`InactivityThreshold`.

Relates to https://github.com/nats-io/nats-server/issues/7102

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>

Run Details

71329 of 83036 relevant lines covered (85.9%)

341902.72 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
2	72.46	-0.45%	src/github.com/nats-io/nats-server/server/avl/seqset.go
2	94.46	0.08%	src/github.com/nats-io/nats-server/server/gateway.go
2	93.59	0.0%	src/github.com/nats-io/nats-server/server/route.go
2	86.19	0.26%	src/github.com/nats-io/nats-server/server/stream.go
3	90.92	-0.12%	src/github.com/nats-io/nats-server/server/leafnode.go
4	81.28	-0.04%	src/github.com/nats-io/nats-server/server/opts.go
9	95.02	-0.2%	src/github.com/nats-io/nats-server/server/client.go
20	72.96	-0.46%	src/github.com/nats-io/nats-server/server/jetstream_api.go
32	81.59	0.03%	src/github.com/nats-io/nats-server/server/jetstream_cluster.go
52	76.63	0.0%	src/github.com/nats-io/nats-server/server/store.go
95	88.05	0.43%	src/github.com/nats-io/nats-server/server/consumer.go
96	86.46	0.84%	src/github.com/nats-io/nats-server/server/raft.go
191	86.05	0.1%	src/github.com/nats-io/nats-server/server/memstore.go
789	84.44	0.71%	src/github.com/nats-io/nats-server/server/filestore.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	16587034244.1	29 Jul 2025 05:55AM UTC	59	85.9	GitHub Action Run

nats-io / nats-server / 16587034244
83%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 16587034244

nats-io / nats-server / 16587034244 83%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 16587034244

nats-io / nats-server / 16587034244
83%

README BADGES
x