moonbitlang / core / 546

92%

Build Type

push

github

Committed by bobzhang

Commit Message

align String::pad_start with JS semantics (not counting char length)

the rationale is that counting char_length is not enough, we need do more complex graphime.

Bottom Line
I'd follow JavaScript's semantics because:
It maintains consistency with your UTF-16-based API
It's predictable and performant
Most real padding use cases don't involve emojis
You can always add character-aware variants later if needed
The current design mixing UTF-16 offsets with character counting creates more confusion than the occasional visual incorrectness with emojis.

Run Details

8 of 8 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

8531 of 9468 relevant lines covered (90.1%)

226093.61 hits per line