ovn-kubernetes / libovsdb / 16526219200

49%

main: 50%

Build Type

Pull #424

github

Committed by dave-tucker

Commit Message

fix: Set context timeout

When calling o.rpcClient.CallWithContext it was possible for this
to block indefinitely waiting for a response from the server.
This would eventually cause a deadlock since rpcMutex would never
be released.

When inactivityTimeout is set we set the timeout on the context
when calling o.rpcClient.CallWithContext. If a response is not received
within the deadline (now + timeout) the call returns with an error
from the context - DeadlineExceeded. At this point the mutex
is released.

Fixes: #391

Signed-off-by: Dave Tucker <dave@dtucker.co.uk>

Pull Request Pull Request #424: Attempt to fix deadlock

Run Details

14 of 15 new or added lines in 1 file covered. (93.33%)

18 existing lines in 1 file now uncovered.

5962 of 12214 relevant lines covered (48.81%)

126.26 hits per line