Ouranosinc / xclim / 16508931188

92%

Build Type

push

github

Committed by web-flow

Commit Message

Assume daily frequency when inferring units of a count or integral index (#2217)

<!--Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [x] This PR addresses an already opened issue (for bug fixes /
features)
    - This PR fixes #2215
- [ ] Tests for the changes have been added (for bug fixes / features)
- [x] (If applicable) Documentation has been added / updated (for bug
fixes / features)
- [x] CHANGELOG.rst has been updated (with summary of main changes)
- [x] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added

### What kind of change does this PR introduce?
`deffreq` is passed from the index function to `infer_sampling_units`
via `to_agg_units` when it matters.

This allows an index to define a default frequency to assume if the data
has missing steps, useful when the units depends on it, when
`op='count'` or `op='integral'`.

This way, indices that are clearly written with daily inputs in mind or
that do not make sense for other frequencies anyway can avoid failing on
data with a few missing days.

Indicators still have the data check that will fail on non-inferrable
time coordinates, and that can also be disabled.

### Does this PR introduce a breaking change?
No, what worked before still works the same. Some cases that failed
before don't fail anymore.

Run Details

57 of 61 new or added lines in 6 files covered. (93.44%)

1 existing line in 1 file now uncovered.

7670 of 8309 relevant lines covered (92.31%)

8.09 hits per line