google / OpenSK / 16464802298

97%

2.1: 97%

Build Type

push

github

Committed by web-flow

Commit Message

Ed25519 in Env (#740)

* Moves Ed25519 into Env

The `ecdsa` trait is renamed to `ec_signing` to indicate that we can
implement more than one curve.
Also removes the `verify_prehash` from the EC trait. This function was
only used outside of the library, and in the function that needs it, we
use the ECDSA crate directly.
Similarly, other functions are only used in tests and now marked as
such.

* Removes test only EC functions

Makes cryptography easier to implement by removing some function that
were used for tests only. These tests are either rewritten or removed.

* Improves test coverage

`PrivateKey` is never cloned in tests, so the code was unused.
One new function was untested, so I added a test for it.

* Fixes Ed25519 to work with WebAuthn

We did not use the correct signature encoding, and the algorithm
identifier was not set in `ctap/mod.rs`.
Also, we now correctly parse from CBOR and check if the parameters make
sense in combination if Ed25519 is enabled.

* Splits the EC signing trait

There are two main differences between ECDSA and Ed25519 that were not
accounted for:

- The public key has x and y components for ECDSA, only x for Ed25519.
- The signature is DER encoded for ECDSA, and plain bytes for Ed25519.

There are new Ecdsa and Ed25519 traits that replaces their common
trait before.

Run Details

193 of 197 new or added lines in 8 files covered. (97.97%)

1 existing line in 1 file now uncovered.

11898 of 12247 relevant lines covered (97.15%)

11469.61 hits per line