babelfish-for-postgresql / babelfish_extensions / 16456893135

76%

BABEL_5_X_DEV: 77%

Build Type

push

github

Committed by web-flow

Commit Message

Introduce additional failure mechanism for broken views as safety check (#3973)

This change enhances the broken view handling mechanism by adding an additional layer of protection. While our primary view repair mechanism should catch and fail when attempting to repair broken views (with errors like "relation does not exist"), this change adds a failsafe mechanism to ensure broken views always fail explicitly rather than potentially returning NULL values. The expected scenario is that this view function will never ever be reached during execution but if due to some uncertainty it does then this will guarantee error instead of incorrect results.

This PR includes following changes:

Added new system function sys.babelfish_broken_view_function() in sys_functions.sql that raises an explicit error
Updated create_dummy_view_query_for_broken_view() to include a WHERE clause that triggers this function
Updated is_dummy_view() to recognize dummy view should have above WHERE func() = 1 in it's query

Issues Resolved: BABEL - 5974
Signed-off-by: Rahul Parande <rparande@amazon.com>

Run Details

20 of 20 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

49661 of 65650 relevant lines covered (75.65%)

317570.69 hits per line