tarantool / tarantool / 16418352555

88%

Build Type

push

github

Committed by sergepetrenko

Commit Message

box: change uuid validation in iproto requests

In the previous patch #11531 we banned connecting to replicas with nil
`instance_uuid` in all iproto requests, including `IPROTO_FETCH_SNAPSHOT`.
It is necessary to allow passing a nil `instance_uuid` to this iproto
request, because:
1) For `IPROTO_FETCH_SNAPSHOT` it became possible to pass an
`instance_uuid`only starting with Tarantool 3.3.
2) While implementing the patch #10755 we wanted to leave `instance_uuid`
field optional for this type of iproto request.

To fix this issue we move checking of nil `instance_uuid` from
`box_connect_replica` to appropriate box functions of each iproto
replication request, excluding `IPROTO_FETCH_SNAPSHOT`.

Also we change some tests:
1) `gh_11531_crash_in_anonymous_subscribe_request_test`: add timeout in
   retrying block in order to avoid flakies. The master node may not be
   able to establish connection during 5 sec. with `net_box` instance.
2) `persistent_gc_anon_test`: introduce `read_fetch_snapshot_response`
   into `test_fetch_snapshot_no_uuid` in order to expect a correct
   iproto response of `IPROTO_FETCH_SNAPSHOT`.

Closes #11668

NO_DOC=bugfix
NO_CHANGELOG=unreleased

Run Details

70775 of 124597 branches covered (56.8%)

6 of 8 new or added lines in 1 file covered. (75.0%)

40 existing lines in 9 files now uncovered.

103965 of 118698 relevant lines covered (87.59%)

1408673.45 hits per line