grpc / grpc-java / #19912
89%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 615
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 88.569% (-0.03%) from 88.601%
#19912

push

github

ejona86 
LBs should avoid calling LBs after lb.shutdown()

LoadBalancers shouldn't be called after shutdown(), but RingHashLb could
have enqueued work to the SynchronizationContext that executed after
shutdown(). This commit fixes problems discovered when auditing all LBs
usage of the syncContext for that type of problem.

Similarly, PickFirstLb could have requested a new connection after
shutdown(). We want to avoid that sort of thing too.

RingHashLb's test changed from CONNECTING to TRANSIENT_FAILURE to get
the latest picker. Because two subchannels have failed it will be in
TRANSIENT_FAILURE. Previously the test was using an older picker with
out-of-date subchannelView, and the verifyConnection() was too imprecise
to notice it was creating the wrong subchannel.

As discovered in b/430347751, where ClusterImplLb was seeing a new
subchannel being called after the child LB was shutdown (the shutdown
itself had been caused by RingHashConfig not implementing equals() and
was fixed by a8de9f07ab, which caused ClusterResolverLb to replace its
state):

```
java.lang.NullPointerException
	at io.grpc.xds.ClusterImplLoadBalancer$ClusterImplLbHelper.createClusterLocalityFromAttributes(ClusterImplLoadBalancer.java:322)
	at io.grpc.xds.ClusterImplLoadBalancer$ClusterImplLbHelper.createSubchannel(ClusterImplLoadBalancer.java:236)
	at io.grpc.util.ForwardingLoadBalancerHelper.createSubchannel(ForwardingLoadBalancerHelper.java:47)
	at io.grpc.util.ForwardingLoadBalancerHelper.createSubchannel(ForwardingLoadBalancerHelper.java:47)
	at io.grpc.internal.PickFirstLeafLoadBalancer.createNewSubchannel(PickFirstLeafLoadBalancer.java:527)
	at io.grpc.internal.PickFirstLeafLoadBalancer.requestConnection(PickFirstLeafLoadBalancer.java:459)
	at io.grpc.internal.PickFirstLeafLoadBalancer.acceptResolvedAddresses(PickFirstLeafLoadBalancer.java:174)
	at io.grpc.xds.LazyLoadBalancer$LazyDelegate.activate(LazyLoadBalancer.java:64)
	at io.grpc.xds.LazyLoadBalancer$LazyDelegate.requestConnec... (continued)

34672 of 39147 relevant lines covered (88.57%)

0.89 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
1
77.08
 -1.04% ../servlet/src/main/java/io/grpc/servlet/AsyncServletOutputStreamWriter.java
2
81.05
 -2.11% ../okhttp/src/main/java/io/grpc/okhttp/ExceptionHandlingFrameWriter.java
2
92.89
 -0.28% ../okhttp/src/main/java/io/grpc/okhttp/OkHttpClientTransport.java
3
92.38
 -0.95% ../xds/src/main/java/io/grpc/xds/client/ControlPlaneClient.java
3
81.4
 -3.22% ../xds/src/main/java/io/grpc/xds/LazyLoadBalancer.java
5
83.02
 -9.43% ../core/src/main/java/io/grpc/internal/Http2Ping.java
16
93.43
 0.01% ../core/src/main/java/io/grpc/internal/ManagedChannelImpl.java
22
79.37
 0.0% ../api/src/main/java/io/grpc/LoadBalancer.java
Jobs
ID Job ID Ran Files Coverage
1 #19912.1 615
88.57
Source Files on build #19912