agama-project / agama / 16320484995

74%

Build Type

push

github

Committed by web-flow

Commit Message

nm-adapter: fix deletion of controller connection (#2564)

## Problem
Deletion of `bridge` or `bonding` connections doesn't work.

## Solution
If a controller connection is deleted, we need to make sure that we do
not update the ports, otherwise we will face the dbus error:

```
agama-web-server[2517]: Could not process the connection en0: D-Bus
 service error: org.freedesktop.NetworkManager.DependencyFailed: Can not
 find a controller for en0: Connection or device bridgeA not found
```

This fix, consider port connections also as removed, once the
corresponding controller connection is removed.


## Testing

- *Tested manually*

## Reproducer

```bash
 agama config load <<<'{
 "network": {
   "connections": [
     {
       "id": "bridgeA",
       "method4": "manual",
       "method6": "disabled",
       "addresses": [
"198.18.10.10/24"
       ],
       "ignoreAutoDns": false,
       "interface": "bridgeA",
       "status": "up",
       "autoconnect": true,
       "persistent": true,
       "bridge": {
       "ports": [ "en0" ]
       }
     }
   ]
 }
}'

agama config load <<<"$(agama config show  | jq '{network: (.network | .connections |= map(if .id == "bridgeA" then .status = "removed" else . end))}')"
```

Run Details

2000 of 3646 branches covered (54.85%)

Branch coverage included in aggregate %.

0 of 7 new or added lines in 1 file covered. (0.0%)

3 existing lines in 2 files now uncovered.

24166 of 37213 relevant lines covered (64.94%)

48.95 hits per line